Open
Conversation
Signed-off-by: misi-bp <mkaloczy@cisco.com>
Made-with: Cursor Signed-off-by: misi-bp <mkaloczy@cisco.com>
… resize Made-with: Cursor Signed-off-by: misi-bp <mkaloczy@cisco.com>
…d overflow-tooltip Made-with: Cursor Signed-off-by: misi-bp <mkaloczy@cisco.com>
Made-with: Cursor Signed-off-by: misi-bp <mkaloczy@cisco.com>
pregnor
reviewed
Apr 4, 2026
pregnor
left a comment
There was a problem hiding this comment.
LGTM, but I'm not in context enough to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR tightens responsive behavior and breakpoint handling across the kit:
AppBreakpointValuesand a singlebreakpointValuesobject (required keys) as the source of truth for pixel widths, passed into MUIbreakpointsand used in mixins/dialog overrides without??fallbacks. Documents how DialogmaxWidthpresets map to those tokens (preset names ≠ layout breakpoint names).window.innerWidth,useState, andwindowresizewithuseTheme()+useMediaQuery(theme.breakpoints.down("sm"), { noSsr: true })so sidenav collapse matches the theme and avoids SSRwindowaccess.windowresizewithResizeObserveron the relevant DOM nodes inBarGraph(Y-axis width vs container) andOverflowTooltip(text overflow vs wrapper). Fixes Rules of Hooks inOverflowTooltipby declaring state before effects.argTypesto describe content widths (M/L/XL) vs layout breakpoints and points readers to the theme docblock.Commits (newest last):
refactor(theme): typed breakpointValues and dialog maxWidth mapping docsfix(layout): use useMediaQuery for sidenav collapse instead of window resizerefactor: use ResizeObserver instead of window resize in bar-graph and overflow-tooltipdocs(storybook): clarify modal content widths vs layout breakpoints🔗 Related Issue
🧪 Type of Change
OverflowTooltiphook orderdialog.tsxbreakpointValues🧪 Testing
yarn test) — confirm in CI / locally;@open-ui-kit/coremay report no unit testsyarn storybook)Test Instructions:
yarn turbo run lint --filter=@open-ui-kit/core(or repo lint) and ensure it passes.Layout; resize below/above 600px (sm); sidenav should collapse/expand; reload on narrow viewport and check for a possible brief flash (noSsr).maxWidth="md"→ 600px paper frombreakpointValues.sm).windowresize only.♿ Accessibility
📱 Responsive Design
down(sm); Modal story documents content widthssm600,md1024)sm/mdboundaries📚 Documentation
maxWidthdescriptionAppBreakpointValues,breakpointValuesfromtheme/common.tsx(consumers importing@/theme/common)🔄 Breaking Changes
Modal/Dialogsignatures unchangedBehavioral notes (non-breaking but worth release notes):
useMediaQuery+noSsr: true).📋 Checklist
dialog.tsxJSDoc tabletscmay have pre-existing issues outside this PRfeat/fix/refactorscope as appropriate📸 Screenshots
For Maintainers: